Skip to content

Custom maps and assorted bugfixes#1662

Closed
glstott wants to merge 27 commits into
CDCgov:devfrom
glstott:custom-maps
Closed

Custom maps and assorted bugfixes#1662
glstott wants to merge 27 commits into
CDCgov:devfrom
glstott:custom-maps

Conversation

@glstott

@glstott glstott commented May 14, 2026

Copy link
Copy Markdown
Collaborator

This addresses several bugs and adds a new feature, custom maps/floorplans.

Specifically, this addresses the following issues:

As part of this pull request, I also included some new cypress tests for #1014 , #1007 , and #1015 .

Change summary:

#966 Custom map/floorplans in angular

  • Added GeoJSON location-file support in the upload flow: validates GeoJSON, detects usable ID fields, extracts feature centers, joins features to nodes, and stores the GeoJSON layer for Map View.
  • Added Map View custom backgrounds for GeoJSON and image floorplans.
  • Added manual node placement on floorplans and regular maps, including node picker, next-unplaced flow, draggable markers, clear selected/all controls, saved coordinate fields, and session restore.
  • Preserved uploaded image aspect ratios by normalizing image floorplans into an x/y coordinate plane.

#963 Auto-Expand Metanode in Map View

  • Added auto-expansion for searched/selected nodes inside collapsed Map View metanodes.
  • Added a toggle to enable/disable auto-expansion.

#385 Maps Are Displayed In Language Of Country

  • Switched online basemap/satellite tiles to Mapbox English-labeled styles.
  • Updated attribution/credit handling and Map View assertions for the new basemap source.

#1648 Decimal/Percentage Mode Bugs In Dev

  • Centralized TN93 distance display conversion/formatting so raw thresholds remain decimal while the UI can show percentages.
  • Added/synchronized the TN93 decimal/percentage control, threshold input, stats text, histogram readout, and style-file persistence.
  • Refreshed dependent views when display format changes, including Aggregate and Heatmap.
  • Added Cypress coverage for TN93 threshold round trips, 2D labels, Table cells, Waterfall rows, Aggregate, Heatmap, and style reapplication.

glstott and others added 20 commits May 4, 2026 09:51
… then manually select placement of nodes on floorplan CDCgov#966
# Conflicts:
#	src/app/filesComponent/files-plugin.component.ts
# Conflicts:
#	src/app/filesComponent/files-plugin.component.ts
@glstott glstott requested a review from dacowan404 May 14, 2026 13:38
Comment thread src/app/filesComponent/files-plugin.component.ts Fixed
Comment thread src/app/filesComponent/files-plugin.component.ts Fixed
Comment thread src/app/filesComponent/files-plugin.component.ts Fixed
Comment thread src/app/filesComponent/files-plugin.component.ts Fixed
Comment thread src/app/filesComponent/files-plugin.component.ts Fixed
Comment thread src/app/filesComponent/files-plugin.component.ts Fixed
@glstott

glstott commented May 22, 2026

Copy link
Copy Markdown
Collaborator Author

Corrections after review:

  • Updated county-level JSON to replace <?> with accented characters (primarily impacting Puerto Rico). Capitalized county names.
  • Found another bug from dev while reviewing commit, the controls hide below nodes when the network is dragged over to the user controls. Made these buttons opaque instead of transparent so this behavior is fixed.
  • Spiderify of metanodes upon search now selects all records that match and spiderifies the node if even just one node is included in the group.
  • Moved custom maps to a new tab on the menu, changed its style to match other file uploads, and added a link to the maps github wiki, where I will add a tutorial on custom maps. A draft is found in docs in this repo.

@glstott

glstott commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

All changes have been moved to individual pull requests by issue, this pull request is now redundant and is being closed.

@glstott glstott closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants