Project 3: Bryce Joseph#37
Open
brycej217 wants to merge 23 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo Link
Core Features Completed
Extended Features Completed
README Completion Checklist
Late Days Used
Code Submission: 3 Late Days
README: 0 Late Days
Project feedback
This project's base code is slightly confusing, and approaches the path tracer in a way which I feel could be more streamlined. The major issue I feel is that in interactions.cu and our Materials struct, it seems like the project wishes for students to approach PBR, as when implementing diffuse we get linked to the PBR textbook site. However, the model that the base code uses is much simpler, and actually looking into PBR might confuse or mislead students. I think in the future the project should lean into either having students implement PBR materials, and modify the materials struct such that they can utilize things like roughness/metallic, or to keep this "PBR-lite" system and have simpler resources for students to implement perfectly diffuse surfaces.
Also I'm tired...