Project 3: Vismay Churiwala#56
Open
vismaychuriwala wants to merge 14 commits into
Open
Conversation
…PT, stochastic sampled anti-alising; and diffuse, reflected and refracted material tracing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to my Repo
Core Features Completed
Extended Features Completed
tin parallel perGeomobject in a separate kernel (highly concurrent but very high memory usage, I will add block reductions fort_minin the future).README Completion Checklist
analysis and descriptions to follow soon.
Late Days Used
Too many - I had been sick for 2 weeks and I asked for an extension on Ed, professor told me to submit it when I could. I finished the core code requirements within 3 late days - but I didn't want to have a minimum project. I have tried added features and make a good readme after the deadline. Sorry for the delay - I've been working on the next assignment in parallel.
Project feedback
I liked the project, but I think the extra features have too little weightage when it comes to points. Features that took me multiple days are weighed 2 points. And these features are ones that make a massive difference in the capabilities of the project like mesh loading. I would've appreciated weightage proportional to time taken.