feat: add warning message and limit selection in dependent views#167
Draft
oltionchampari wants to merge 2 commits into
Draft
feat: add warning message and limit selection in dependent views#167oltionchampari wants to merge 2 commits into
oltionchampari wants to merge 2 commits into
Conversation
thinkh
reviewed
Dec 9, 2021
Member
thinkh
left a comment
thinkh
left a comment
There was a problem hiding this comment.
In general that looks fine to me. I have some suggestions regarding the warning message.
| const {name, selectionLimit} = desc; | ||
| if (selectionLimit && selection.range.size().reduce((a, b) => a + b, 0) > selectionLimit) { | ||
| NotificationHandler.pushNotification('warning', | ||
| `<b>${name}</b>: Supported incoming selections limit reached. Showing data for the first <b>${selectionLimit}</b> items.`, |
Member
There was a problem hiding this comment.
Here is my text suggestion:
Suggested change
| `<b>${name}</b>: Supported incoming selections limit reached. Showing data for the first <b>${selectionLimit}</b> items.`, | |
| `<b>${name}</b>: Too many selected items. Showing data only for the first <b>${selectionLimit} items</b>.`, |
| if (selectionLimit && selection.range.size().reduce((a, b) => a + b, 0) > selectionLimit) { | ||
| NotificationHandler.pushNotification('warning', | ||
| `<b>${name}</b>: Supported incoming selections limit reached. Showing data for the first <b>${selectionLimit}</b> items.`, | ||
| NotificationHandler.DEFAULT_SUCCESS_AUTO_HIDE); |
Member
There was a problem hiding this comment.
5 seconds are very fast, until I detected the warning and started to read, it was already gone. I suggest to increase the time to 10 seconds or maybe let it close by the user.
thinkh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Caleydo/tdp_bi_bioinfodb#1316
tdp_core PR datavisyn/tdp_core#595
Summary
@thinkh Could you test this and see the code changes and let me know if this implementation would be okay.
Then i can go ahead and add this feature to the other two views
Screenshot