fix: validate diff layout, fall back to tab on unknown value#86
Merged
Conversation
An unknown diff layout — a typo like "vspllit", or a layout removed in a future version — silently fell through to the "tabnew" branch, making the config look ignored. Validate the resolved layout (both diff.layout and the per-backend diff.layouts overrides) in the layout_for_backend chokepoint; warn once (log.warn surfaces via vim.notify, so guard against per-diff spam) and fall back to "tab". Surfaced during review of #82 (per-backend layouts) as a pre-existing gap that the new layouts map widened. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates the resolved diff layout and falls back to
tabon an unknown value, instead of silently rendering as a tab with no feedback.An unknown layout — a typo (
"vspllit") or a layout removed in a future version — previously fell through to thetabnewbranch silently, so a misconfigureddiff.layout/diff.layoutslooked ignored. Pre-existing gap surfaced during the #82 review (the per-backendlayoutsmap widened the surface).Changes
diff.lua—valid_layout()check inside thelayout_for_backendresolution chokepoint, covering bothdiff.layoutand the per-backenddiff.layoutsoverrides in one place. Warns once per bad value (via awarned_layoutsguard) and falls back to"tab"— the once-guard matters becauselog.warnfires a user-visiblevim.notify, which would otherwise pop on every diff.tests/— two specs: unknown default layout → tab, unknown per-backend override → tab.Testing
🤖 Generated with Claude Code