Skip to content

feature: basic scrollbar support for tables and dialogs#2046

Merged
ClementTsang merged 2 commits intomainfrom
scrollbars
Apr 25, 2026
Merged

feature: basic scrollbar support for tables and dialogs#2046
ClementTsang merged 2 commits intomainfrom
scrollbars

Conversation

@ClementTsang
Copy link
Copy Markdown
Owner

@ClementTsang ClementTsang commented Apr 23, 2026

Description

A description of the change, what it does, and why it was made. If relevant (e.g. UI changes), please also provide screenshots/recordings:

Adds scrollbars to dialogs (help, process kill) and optionally tables.

Table:

image

Dialogs:
image

image

Example with another theme:

image

Issue

If applicable, what issue does this address?

Closes: #1555

Testing

If relevant, please state how this was tested (including steps):

If this change affects the program, please also indicate which platforms were tested:

  • Windows
  • macOS (specify version below)
  • Linux (specify distro below)
  • Other (specify below)

Checklist

Ensure all of these are met:

  • If this PR adds or changes a dependency, please justify this in the description
  • If this is a code change, areas your change affects have been linted using (cargo fmt)
  • If this is a code change, your changes pass cargo clippy --all -- -D warnings
  • If this is a code change, new tests were added if relevant
  • If this is a code change, your changes pass cargo test
  • The change has been tested to work (see above) and doesn't appear to break other things
  • Documentation has been updated if needed (README.md, help menu, docs, configs, etc.)
  • There are no merge conflicts
  • You have reviewed your changes first
  • The pull request passes the provided CI pipeline

Other

Anything else that maintainers should know about this PR:

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 24.24242% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.04%. Comparing base (5d09d18) to head (b089b69).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/canvas/dialogs/help_dialog.rs 0.00% 25 Missing ⚠️
src/canvas/components/scroll_bar.rs 0.00% 20 Missing ⚠️
src/canvas/components/data_table/draw.rs 33.33% 18 Missing ⚠️
src/canvas/dialogs/process_kill_dialog.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
+ Coverage   55.87%   62.04%   +6.17%     
==========================================
  Files         124      125       +1     
  Lines       17580    17669      +89     
==========================================
+ Hits         9822    10963    +1141     
+ Misses       7758     6706    -1052     
Flag Coverage Δ
macos-14 49.01% <15.15%> (-0.19%) ⬇️
ubuntu-24.04 60.93% <24.24%> (+6.47%) ⬆️
windows-2022 48.70% <17.24%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClementTsang ClementTsang marked this pull request as ready for review April 25, 2026 09:43
@ClementTsang ClementTsang enabled auto-merge (squash) April 25, 2026 09:46
@ClementTsang ClementTsang merged commit 61e5675 into main Apr 25, 2026
37 of 38 checks passed
@ClementTsang ClementTsang deleted the scrollbars branch April 25, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add scrollbars to some elements

1 participant