Migrate feature-flagging groovy tests to java#11716
Migrate feature-flagging groovy tests to java#11716gh-worker-dd-mergequeue-cf854d[bot] merged 14 commits into
Conversation
sarahchen6
added
comp: testing
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
sarahchen6
requested review from
sameerank and
typotter
and removed request for
a team
| return fieldType.cast(field.get(target)); | ||
| } | ||
|
|
||
| private static void eventually(ThrowingRunnable assertion, long timeoutMillis) throws Exception { |
There was a problem hiding this comment.
💭 thought: That might be the kind of utility methods that should go in test-utils modules. WDYT?
There was a problem hiding this comment.
It looks like this file is the only use case for eventually, so may not be worth adding to a shared space 🤔
There was a problem hiding this comment.
Let's keep it that way, I will start a discussion on the Slack channel because I think I found similar usage in the code base already. Don't sweat too much about it for this PR (out of scope).
There was a problem hiding this comment.
I added the capability here and added you as reviewer: #11739
You can wait for it to be merged or I will follow up with another PR to use it in this test suite.
There was a problem hiding this comment.
Sounds good, thanks! I can wait for it to be merged and update this PR directly then
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the migration and follow up changes!
I added two minor comments about the newly opened API.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
sarahchen6/migrate-feature-flagging-tests-to-java
branch
2 participants
What Does This Do
Migrate Groovy tests in the
productsmodule to Java without changing any functionalityMotivation
This is part of a broader initiative to migrate all testing in this repo to JUnit
Additional Notes
Confirmation that we did not lose tests (note that a few tests were combined in this PR):
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]