Skip to content

Display warnings from SetFlags in OnAfterFix #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkromberg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Display warnings from SetFlags in OnAfterFix #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions StartupSession/Link/OnAfterFix.aplf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{linked}←OnAfterFix(obj evt src ns oldname name file);nss;z;stop;trace;link;fullname;relname;nsref;err;new;old;newfile
{linked}←OnAfterFix(obj evt src ns oldname name file);nss;z;stop;trace;link;fullname;relname;nsref;err;new;old;newfile;msg;error
⍝ Thin cover for editor onAfterFix event
⍝ Returns 1 if a link was found for the name, else 0
⍝ NB: if 0 is returned, no ⎕FX/⎕FIX was done
Expand All @@ -24,16 +24,20 @@
:Return
:EndIf

error←0
:Trap 0
:If (⎕NC fullname←(⍕ns),'.',name)∊3 4
relname←(1+≢link.ns)↓fullname
:AndIf ((⊂relname)∊link.flagged)∨0≠≢(stop←⎕STOP fullname),trace←⎕TRACE fullname
z←'Stop'SetFlags(fullname stop)ns ⍬
z←'Trace'SetFlags(fullname trace)ns ⍬
:AndIf ~error←∨/'ERRORS'⍷msg←'Stop'SetFlags(fullname stop)ns ⍬
:AndIf ~error←∨/'ERRORS'⍷msg←'Trace'SetFlags(fullname trace)ns ⍬
:EndIf
:Else
U.Warn'Unable to record Stop/Trace settings'
msg←'Internal error (',(⊃⎕DMX.Message),')'⊣error←1
:EndTrap
:If error
U.Warn 'Unable to record stop/trace bits: ',msg
:EndIf

:Trap 501 ⍝ We do not want to crash inside the editor if Fix signals an error
{}ns name oldname ⎕SE.Link.Fix ⍬ ⍝ on error, we'll bubble up now
Expand Down