Fix XmlReader field name collision in DeserializationBenchmark#3473
Merged
Conversation
2 tasks
Co-authored-by: cknaap <2102470+cknaap@users.noreply.github.com> Agent-Logs-Url: https://github.com/FirelyTeam/firely-net-sdk/sessions/b997651a-e112-4381-89b3-179c44154d8a
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on ISourceNode.ToPoco() implementation PR
Fix XmlReader field name collision in DeserializationBenchmark
Mar 24, 2026
cknaap
approved these changes
Mar 24, 2026
32bfcb7
into
feature/3471-sourcenode-to-poconode
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal XmlReader XmlReaderfield name collides withSystem.Xml.XmlReadertype, causingXmlReader = XmlReader.Create(...)to fail compilation (compiler binds RHSXmlReaderto the field, not the type).Description
XmlReaderclass field fromDeserializationBenchmarksusing var _xmlReader = XmlReader.Create(...)insideXmlDictionaryDeserializer(), resolving the ambiguity and ensuring proper disposal per benchmark iterationRelated issues
Testing
Verified the Benchmarks project builds with 0 warnings and 0 errors.
FirelyTeam Checklist
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.