test(ui): Add enhanced mentions docs screenshots #2778
Conversation
📝 WalkthroughWalkthroughTwo new golden tests are added for documentation screenshots: one validates mention autocomplete with mention types by mocking channel capabilities, members, watchers, and a role search response; the other adds a message fixture builder covering multiple mention kinds and a golden test rendering the message list view. ChangesMention-related docs golden tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/docs_screenshots/test/message_list/message_list_view_test.dart (1)
71-71: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick winUse single quotes for this string literal.
Line 71 uses double quotes; please switch to single quotes to match the Dart style rule in this repo.
Suggested diff
- text: "`@engineering` let's sync on the API changes", + text: '`@engineering` let\'s sync on the API changes',As per coding guidelines, "Prefer const constructors and final locals; use single quotes for strings".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/docs_screenshots/test/message_list/message_list_view_test.dart` at line 71, The string literal assigned to the text parameter uses double quotes instead of single quotes, which violates the Dart style guidelines for this repository. Change the double quotes around the string "`@engineering` let's sync on the API changes" to single quotes to match the preferred style rule for string literals.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/docs_screenshots/test/message_list/message_list_view_test.dart`:
- Line 71: The string literal assigned to the text parameter uses double quotes
instead of single quotes, which violates the Dart style guidelines for this
repository. Change the double quotes around the string "`@engineering` let's sync
on the API changes" to single quotes to match the preferred style rule for
string literals.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: df33c1fd-e607-4c74-b505-2755d87db6bb
⛔ Files ignored due to path filters (2)
docs/docs_screenshots/test/message_input/goldens/macos/autocomplete_trigger_mention_types.pngis excluded by!**/*.pngdocs/docs_screenshots/test/message_list/goldens/macos/message_list_view_mentions.pngis excluded by!**/*.png
📒 Files selected for processing (2)
docs/docs_screenshots/test/message_input/autocomplete_triggers_test.dartdocs/docs_screenshots/test/message_list/message_list_view_test.dart
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2778 +/- ##
=======================================
Coverage 69.59% 69.59%
=======================================
Files 426 426
Lines 25675 25675
=======================================
Hits 17868 17868
Misses 7807 7807 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Submit a pull request
CLA
Description of the pull request
Adds docs screenshots for enhanced mentiones
Screenshots / Videos
See the goldens
Summary by CodeRabbit