Change TimeOnly.ToClockNotation to accept culture#1537
Open
RenNagasaki wants to merge 8 commits into
Open
Conversation
… Culture is different than the wanted culture.
hangy
reviewed
Aug 24, 2024
| @@ -1,4 +1,4 @@ | |||
| [MemoryDiagnoser(false)] | |||
| [MemoryDiagnoser(false)] | |||
Contributor
There was a problem hiding this comment.
The first line of every file you modified seems to be changed. Is this a modified BOM? I'm not sure if there's a preferred version in the project, but you might want to check this.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There are cases where your UI culture is not the culture you want to get the clock notation for. Added the functionality for that.
Existing implementations should not be influenced.
For me the problematic part is: I use the DefaultTimeOnlyToClockNotationConverter for english clock notation but my UI culture is 'de-DE'. I get for 08:15 -> 'a quarter past acht' instead of 'a quarter past eight'
Here is a checklist you should tick through before submitting a pull request:
mainbranch (more info below)fixes #<the issue number>build.cmdorbuild.ps1and ensure there are no test failures