Add initial documentation for context menu for linked file moval#15597
Add initial documentation for context menu for linked file moval#15597koppor wants to merge 7 commits into
Conversation
| --- | ||
| nav_order: 56 | ||
| parent: Decision Records | ||
| status: accepted |
There was a problem hiding this comment.
Because we don't have it in the other ADRs I assume
|
|
||
| JabRef supports up to four file directory types for linked files: | ||
|
|
||
| * **X1 — Main file directory**: set in global preferences; accessible to the current user only |
There was a problem hiding this comment.
Not sure if X1, X2, are needed.
- Should there be a dot at the end?
| * Good, because adding or removing a directory configuration is immediately reflected in the menu. | ||
| * Bad, because users with all three directories configured see up to three items, which is more verbose than a single entry. | ||
|
|
||
| ### Confirmation |
There was a problem hiding this comment.
I think this section is optional
| status: accepted | ||
| date: 2026-04-20 | ||
| --- | ||
| # Multi-file move uses a single chosen target directory for all selected files |
There was a problem hiding this comment.
| # Multi-file move uses a single chosen target directory for all selected files | |
| # Multi-file move should use a single target directory for all selected files |
There was a problem hiding this comment.
Isn't this behaviour obvious? It would be strange if I performed a move action to 1 directory and files would end up in different. Maybe I don't understand fully the context
Co-authored-by: Ruslan <ruslanpopov1512@gmail.com>
|
Removed ADRs - included the alternatives in the requirements at |
Review Summary by QodoAdd requirements documentation for linked file directory movement
WalkthroughsDescription• Add comprehensive requirements documentation for linked file movement feature • Define four directory types (MD, LSD, USD, LD) and their scopes • Specify context menu behavior for moving files between directories • Document design decisions and rejected alternatives Diagramflowchart LR
A["Linked File Move Feature"] --> B["Directory Types Defined"]
A --> C["Context Menu Requirements"]
A --> D["File Movement Logic"]
A --> E["Design Alternatives"]
B --> F["MD, LSD, USD, LD"]
C --> G["Show All Configured Dirs"]
C --> H["Disable Current Directory"]
D --> I["Preserve Subdirectory Structure"]
E --> J["Rejected Designs Documented"]
File Changes1. docs/requirements/linked-file-move-between-directories.md
|
Code Review by Qodo
1. Invalid Needs syntax
|
InAnYan
left a comment
There was a problem hiding this comment.
The approach with requirements is quite interesting.
Only nitpicks:
- I would introduce feature and in the requirements wrote "Covers"
- To turn off "Needs:" one could also write:
<--! oft:on --->
<--! oft:off --->
(HTML comment, I forgot the exact syntax, but the contents of the comment is right)
- Also the requirements when "library is not saved" and "no directory set" - they are not equal?
Related issues and pull requests
Refs #12287
PR Description
We have some disussions at the PR #15055
This should bring in some clarity.
Steps to test
Read and try to follow - or update
Checklist
CHANGELOG.mdin a way that can be understood by the average user (if change is visible to the user)