fix: use loguru's InterceptHandler to route stdlib logging into loguru#374
Merged
Conversation
- fixes problem where cluster_api would crash because the stdlib logging didn't accept loguru's log_level TRACE. See also the quick-fix in #357, which got deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fxes problem where cluster_api would crash because the stdlib logging didn't accept loguru's log_level TRACE. See Konrad's reply to the quick-fix in #357. That quick fix got deleted in the worker refactoring PR.
@krokicki