refactor(cli): inline question-tool client gating#9735
Open
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Open
refactor(cli): inline question-tool client gating#9735kilo-code-bot[bot] wants to merge 2 commits intomainfrom
kilo-code-bot[bot] wants to merge 2 commits intomainfrom
Conversation
Moves the `questionEnabled` check back inline in `tool/registry.ts` instead of delegating to `KiloToolRegistry.question()`. The extracted helper changed the shape of the upstream line, making the shared file harder to rebase during opencode merges. Inlining keeps the diff local to that one line (just adding "vscode" to the allowed clients) so future merges conflict less.
Contributor
Author
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.5-2026-04-23 · 134,137 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🚨 DO NOT MERGE BEFORE THE OPENCODE v1.14.29 MERGE 🚨
Inlines the question-tool client gating back into
packages/opencode/src/tool/registry.tsinstead of going throughKiloToolRegistry.question(). Extracting that one-liner into a helper reshaped the surrounding upstream line, which was making the opencode rebase harder than it needed to be. Inlining keeps the only real Kilo delta (adding"vscode"to the allowed clients) as a single-linekilocode_changepatch over the upstream code — much easier to carry across merges.Also drops the now-unused
KiloToolRegistry.question()export.