[Core] Fix ModelPartIO to write the submodelparts names without spaces#14496
Open
loumalouomega wants to merge 2 commits into
Open
[Core] Fix ModelPartIO to write the submodelparts names without spaces#14496loumalouomega wants to merge 2 commits into
ModelPartIO to write the submodelparts names without spaces#14496loumalouomega wants to merge 2 commits into
Conversation
Contributor
|
I'd just prohibit spaces (and other unwanted characters) in the With this PR we'd have inconsistent behavior: |
Member
Author
Yes, but if I modify the model part or model class to restrict the naming the PR will take ages. |
Contributor
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


name: ✨ Feature
about: Fix
ModelPartIOto write the submodelparts names without spaces📝 Description
The write is correct, but if you try to read it later, it fails as the spaces are not properly processed in the read.
Key changes
ModelPartIOto write the submodelparts names without spaces🆕 Changelog
ModelPartIOto write the submodelparts names without spaces