Skip to content

[Core] Fix ModelPartIO to write the submodelparts names without spaces#14496

Open
loumalouomega wants to merge 2 commits into
masterfrom
io/minor-fix-submodelpart-write-modelpartio
Open

[Core] Fix ModelPartIO to write the submodelparts names without spaces#14496
loumalouomega wants to merge 2 commits into
masterfrom
io/minor-fix-submodelpart-write-modelpartio

Conversation

@loumalouomega

Copy link
Copy Markdown
Member

name: ✨ Feature
about: Fix ModelPartIO to write the submodelparts names without spaces


📝 Description

The write is correct, but if you try to read it later, it fails as the spaces are not properly processed in the read.

Key changes

  • Fix ModelPartIO to write the submodelparts names without spaces

🆕 Changelog

@loumalouomega loumalouomega requested a review from a team as a code owner June 12, 2026 09:43
@loumalouomega loumalouomega added Kratos Core Hotfix FastPR This Pr is simple and / or has been already tested and the revision should be fast IO labels Jun 12, 2026
@loumalouomega loumalouomega enabled auto-merge June 12, 2026 09:43
@matekelemen

matekelemen commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

I'd just prohibit spaces (and other unwanted characters) in the ModelPart constructor.

With this PR we'd have inconsistent behavior:
write model part => read written model part => model parts written and read are different

@loumalouomega

Copy link
Copy Markdown
Member Author

I'd just prohibit spaces (and other unwanted characters) in the ModelPart constructor.

With this PR we'd have inconsistent behavior: write model part => read written model part => model parts written and read are different

Yes, but if I modify the model part or model class to restrict the naming the PR will take ages.

@matekelemen

Copy link
Copy Markdown
Contributor
image

That's a problem with this project's governance (I know your pain and have the same opinion), but that should not affect behavior / code quality.

@loumalouomega

Copy link
Copy Markdown
Member Author
image

That's a problem with this project's governance (I know your pain and have the same opinion), but that should not affect behavior / code quality.

¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FastPR This Pr is simple and / or has been already tested and the revision should be fast Hotfix IO Kratos Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants