[TrilinosApplication] Fix ReadMatrix and TrilinosExperimentalSpace function to use getLocalNumRows for local row count#14506
Open
loumalouomega wants to merge 8 commits into
Open
Conversation
…for local row count
ReadMatrix function to use getLocalNumRows for local row countReadMatrix and TrilinosExperimentalSpace function to use getLocalNumRows for local row count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: ✨ Feature
about: Support Trilinos 16.1+ by adding API probe for row-count method
📝 Description
getNodeNumRows()method fromTpetra::CrsMatrix.Builds against Trilinos 16.1+ fail with:
SFINAEoverload resolution to detect which method is available:getLocalNumRows()first (Trilinos 16.1+)getNodeNumRows()(older versions)This approach requires no version macros and works automatically across all Trilinos versions without user configuration.
Key changes
Detail::GetNumLocalRows<TMatrix>()helper that dispatches to the appropriate implementation at compile time.intparameter prefers the newer API.longparameter acts as fallback.ReadMatrix()to use the helper.Validation
getNodeNumRows) and Trilinos 16.1 (withgetLocalNumRows)🆕 Changelog
ReadMatrixfunction to usegetLocalNumRowsfor local row countGetNumLocalRowsutility toTrilinosExperimemntalSpace