Update Placable.Token to match Foundry v13.351#3565
Open
henry-malinowski wants to merge 146 commits into
Open
Conversation
henry-malinowski
force-pushed
the
pr/token-is-dragged
branch
from
a4b2a5d to
4f1fa57
Compare
henry-malinowski
force-pushed
the
pr/token-is-dragged
branch
from
dc8354a to
1eb6fb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placable Token: update to match v13.351 source.
Context:
This started because I was working on improving instant-range's type usage (where I had been forced to use
anydue to incomplete types for >=v13). In particularisDraggedbeing missing. Since I already needed to make changes in the Placeable.Token file, I decided to expand the scope of the change to reviewing and fixing the Token file as a whole, since I figured there were other points of drift that could use some updating for me in the future or other people.The main changes are as follows:
isDragged,effects,targetArrows,targetPips,ruler,turnMarkertarget(split intotargetArrows/targetPipssince v13)getDispositionColor(),createTerrainMovementPath()combatant,sourceElementnullabilityshape/getShape()to includeCircle | EllipseAnimateOptions,ConstrainMovementPathWaypoint,PlannedMovement, etc.)TokenGEtTerrainMovementPathWaypointNote: I had to commit with --no-verify because the playwrite system was bugging out despite successfully logging into my Foundry instance.