fix: deduplicate ogImages by URL before upsert to prevent unique constraint violation#774
Open
writsop wants to merge 1 commit intoMerit-Systems:mainfrom
Open
fix: deduplicate ogImages by URL before upsert to prevent unique constraint violation#774writsop wants to merge 1 commit intoMerit-Systems:mainfrom
writsop wants to merge 1 commit intoMerit-Systems:mainfrom
Conversation
…traint violation When multiple OG images share the same URL, the parallel upsert calls race on the (originId, url) unique constraint causing PrismaClientKnownRequestError P2002. Deduplicate the array by URL using a Map before upserting, keeping the last occurrence (matching current upsert "last write wins" semantics). Fixes Merit-Systems#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple OG images share the same URL (e.g. from meta tags), the parallel
Promise.allupsert calls race on the(originId, url)unique constraint, causingPrismaClientKnownRequestError P2002.Fix
Deduplicate the
ogImagesarray by URL using aMapbefore upserting, keeping the last occurrence (matching the current upsert "last write wins" semantics).Fixes #287