Conversation
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (1 files, +7 -3)
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d1a444. Configure here.
Builds ready [1d1a444]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [9f18008]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [899637a] [reused from 1d1a444]
⚡ Performance Benchmarks (Total: 🟢 5 pass · 🟡 3 warn · 🔴 0 fail)
Bundle size diffs
|
…redirect-user-back-to-drawer
Builds ready [ca0fb37]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
…redirect-user-back-to-drawer
|
Builds ready [c97f746]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|




This PR ensures that when user click on the back button in settings, it should redirect the user back to homepage with drawer open state
Description
Changelog
CHANGELOG entry: settings back button update in full screen
Related issues
Fixes: issue
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes routing logic for the settings header back button across environment types; small but user-facing and could impact navigation flows if route meta/parent paths are relied on elsewhere.
Overview
Updates Settings V2 back-button behavior so fullscreen settings (including sub-pages) always navigate back to
${DEFAULT_ROUTE}?drawerOpen=true, instead of returning to a parent settings tab.Adjusts E2E navigation to click the actual back button (and close the drawer afterward) and adds a unit test covering fullscreen sub-page back navigation.
Reviewed by Cursor Bugbot for commit c97f746. Bugbot is set up for automated code reviews on this repo. Configure here.