feat: TO-541 - Integrate passkey in onboarding and unlock page#42169
Open
tanguyenvn wants to merge 13 commits intofeat/TO-541-passkey-unlockfrom
Open
feat: TO-541 - Integrate passkey in onboarding and unlock page#42169tanguyenvn wants to merge 13 commits intofeat/TO-541-passkey-unlockfrom
tanguyenvn wants to merge 13 commits intofeat/TO-541-passkey-unlockfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨📜 @MetaMask/policy-reviewers (12 files, +168 -0)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔐 @MetaMask/web3auth (6 files, +733 -3)
|
tanguyenvn
added
team-onboarding
Contributor
Builds ready [b5b6fd0]
⚡ Performance Benchmarks (Total: 🟢 6 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [d5b9d36]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
tanguyenvn
force-pushed
the
feat/TO-541-passkey-setup-and-unlock
branch
from
d5b9d36 to
d7eac43
Compare
Contributor
Builds ready [d7eac43]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [e1bde4f]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [4e6a0ef]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
tanguyenvn
force-pushed
the
feat/TO-541-passkey-setup-and-unlock
branch
from
4e6a0ef to
5e9f8f2
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [1b15cec]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [707bc60]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
tanguyenvn
commented
Apr 28, 2026
| (firstTimeFlowType === FirstTimeFlowType.import || | ||
| firstTimeFlowType === FirstTimeFlowType.create) | ||
| ) { | ||
| navigate(ONBOARDING_SETUP_PASSKEY_ROUTE, { replace: true }); |
Contributor
Author
There was a problem hiding this comment.
should not allow in sidepanel mode
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 259b5ea. Configure here.
| </Button> | ||
| </Box> | ||
| </form> | ||
| )} |
There was a problem hiding this comment.
Passkey unlock view missing form wrapper breaks keyboard submission
Low Severity
When showPasswordUnlockForm is false, the passkey view is rendered as a plain Box instead of a form. The outer Box with asChild (line 809) expects to merge its props — including data-testid="unlock-page" — into its single child. The password branch is a <form> so asChild works naturally, but the passkey branch is a non-form <Box> that still receives the form-related context from the parent. More importantly, the "Unlock with biometrics" button will never be reachable via Enter/keyboard submission since there is no <form> and the button is type="button".
Reviewed by Cursor Bugbot for commit 259b5ea. Configure here.
|
|
||
| if (isFirefox || isSocialLoginFlow) { | ||
| if (isPasskeyFeatureAvailable && !isSocialLoginFlow) { | ||
| navigate(ONBOARDING_SETUP_PASSKEY_ROUTE, { replace: true }); |
There was a problem hiding this comment.
Redundant isSocialLoginFlow guard masks intent of passkey check
Low Severity
isPasskeyFeatureAvailable && !isSocialLoginFlow is redundant — getIsPasskeyFeatureAvailable already includes !getIsSocialLoginFlow(state) internally. This same redundancy appears in the unlock page container where isPasskeyActive combines getIsPasskeyFeatureAvailable(state) with !isSocialLoginFlow. The double-checking obscures the actual invariant and could mislead future maintainers into thinking the inner check might be absent.
Reviewed by Cursor Bugbot for commit 259b5ea. Configure here.
|
Contributor
Builds ready [259b5ea]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the initial passkey (biometric/WebAuthn) experience across onboarding and unlock flows, and wires the background/controller APIs needed to register, authenticate, and manage passkeys safely.
Context
Solution
Changelog
CHANGELOG entry: Added passkey setup during onboarding and passkey-based unlock with password fallback.
Related issues
Fixes: TO-541
Manual testing steps
PASSKEY_ENABLED=true) and run the extension.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
High Risk
Adds a new WebAuthn/passkey unlock path and related background RPC actions, affecting core authentication/unlock behavior and onboarding routing. Risk comes from changes to lock/unlock flows, auto-unlock behavior, and new error/feature-gating logic across multiple surfaces.
Overview
Adds a new onboarding step at
ONBOARDING_SETUP_PASSKEY_ROUTEthat lets users enroll biometrics/passkeys (or skip via Maybe later), and updatesCreatePassword/OnboardingFlowrouting to insert this step when the passkey feature is available and not yet registered.Updates the unlock UI to support passkey unlocking (including optional auto-attempt when eligible and not suppressed), fallback to password via Use password, sidepanel troubleshooting that opens the full-screen unlock route, and localized passkey error messaging/metrics.
Introduces new selectors (
getIsPasskeyFeatureAvailable,getIsPasskeyRegistered), new background-facing actions for passkey registration/authentication and passkey-verified password change/removal, and updates LavaMoat policies plus i18n strings to allow/use@simplewebauthn/browserand new UI copy.Reviewed by Cursor Bugbot for commit 259b5ea. Bugbot is set up for automated code reviews on this repo. Configure here.