fix: inlude hip3 categorization on perps market list cp-13.29.0#42170
Merged
Conversation
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/perps (2 files, +63 -20)
|
Contributor
Builds ready [7cc2642]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [afd943f]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
changed the title
geositta
reviewed
Apr 27, 2026
geositta
left a comment
geositta
left a comment
Contributor
There was a problem hiding this comment.
Since this relies on the controller/data layer continuing to limit which HIP-3 markets reach the UI when the feature flag state is incomplete, should we have an integration test at that boundary?
Contributor
Builds ready [54d3c28]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
geositta
approved these changes
Apr 27, 2026
Contributor
Builds ready [fa6d106]
⚡ Performance Benchmarks (Total: 🟢 7 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
michalconsensys
approved these changes
Apr 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.30.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Stocks, Commodities, and Forex tabs in the perps market list were rendering empty even though HIP-3 markets were visible and tradable under "All".
The filter was gating each category on isHip3Market(m, allowedHip3Sources), where allowedHip3Sources comes from the perpsHip3AllowlistMarkets LaunchDarkly flag. The UI-side selector defaults to an empty set when the flag hasn't loaded yet — so every market failed the allowlist check, leaving all three category tabs blank.
Meanwhile, the background controller has a hardcoded fallbackHip3AllowlistMarkets: ['xyz:*'], which is why the markets appear tradable under "All" but disappear when a category filter is selected.
Fix:
Remove the isHip3Market gate from the stocks, commodities, and forex filter cases. These tabs now filter purely on the resolved marketType (equity, commodity, forex), which is already correctly populated by the controller's transformMarketData.
This is safe because:
The controller's own allowlist already controls which HIP-3 markets reach the UI — re-checking it in the UI filter is redundant and produces a false negative when the flag is empty.
getResolvedMarketType returns undefined for crypto and unmapped markets, so no non-HIP-3 markets can bleed through.
The all, crypto, and new tab logic is unchanged.
Changelog
CHANGELOG entry: fixes bug where hip3 assets weren't discoverable in search
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TAT-3096
Manual testing steps
Screenshots/Recordings
Screen.Recording.2026-04-27.at.10.31.04.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes market-category filtering logic for perps, which can affect what markets are surfaced to users if market typing or controller gating is incorrect. Added tests reduce risk by asserting both UI behavior when the LaunchDarkly allowlist flag is missing and that the controller fallback allowlist remains non-empty.
Overview
Fixes the perps market list category tabs (Stocks/Commodities/Forex) rendering empty when the
perpsHip3AllowlistMarketsremote feature flag hasn’t loaded.The UI filter now categorizes these tabs only by resolved market type (equity/commodity/forex) instead of additionally gating on the allowlist set; the allowlist is still used for the "New" tab. New tests cover category tab rendering with the flag absent and add a guard asserting
PerpsControllerInitalways wires a non-emptyfallbackHip3AllowlistMarketsso HIP-3 markets are gated before LaunchDarkly responds.Reviewed by Cursor Bugbot for commit fa6d106. Bugbot is set up for automated code reviews on this repo. Configure here.