fix: unlock redirect back loop#42184
Merged
HowardBraham merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
AndyMBridges
approved these changes
Apr 28, 2026
NidhiKJha
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes the redirect loop when auto unlocking
Changelog
CHANGELOG entry: fix: replace unlock redirect history entry
Related issues
Fixes: #42004
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: only adjusts
react-routernavigation options on unlock redirects, with updated tests; main behavior change is back/forward history handling.Overview
Fixes an unlock redirect loop by changing post-unlock redirects to use
navigate(..., { replace: true })(both for auto-unlock inUnlockPageand for manual unlock submit in the container), preventing an extra history entry from being added.Updates
UnlockPagetests to assert the newreplace: truenavigation behavior for redirects driven bylocation.state.from.Reviewed by Cursor Bugbot for commit d562049. Bugbot is set up for automated code reviews on this repo. Configure here.