Add config_path parameter, /config directory for docker image and cookie env vars#377
Open
RobinMeis wants to merge 6 commits intoMichele0303:mainfrom
Open
Add config_path parameter, /config directory for docker image and cookie env vars#377RobinMeis wants to merge 6 commits intoMichele0303:mainfrom
RobinMeis wants to merge 6 commits intoMichele0303:mainfrom
Conversation
Owner
|
Hey @RobinMeis, thanks for this PR. The problem is that the codebase has changed significantly since November, The conflicts are too deep for a simple rebase. Could you open a new PR based on current main? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the following improvements which are mainly intended for the docker image:
-config-pathparameter allows to specify a user defined configuration directory forcookies.jsonandtelegram.json./configas configuration directory. This allows to mount a volume into the docker container containing the configuration files.SESSIONID_SSandTT_TARGET_IDC. If at leastSESSIONID_SSis specified, the cookies.json file will be automatically created on container startup. This feature improves secret management in K8S clusters.