Skip to content

Add filters for custom data#45

Open
groenroos wants to merge 4 commits into
MindscapeHQ:masterfrom
groenroos:feature/custom-data
Open

Add filters for custom data#45
groenroos wants to merge 4 commits into
MindscapeHQ:masterfrom
groenroos:feature/custom-data

Conversation

@groenroos

Copy link
Copy Markdown
  • Add WordPress filters raygun_custom_data and raygun_js_custom_data for optionally populating the user custom data of both PHP and JS errors
  • Resolves Hook to attach custom data #44

@QuantumNightmare QuantumNightmare left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I'm not too familiar with wordpress development, and so have utilized AI to help with the review. A colleague who's more familiar than I may also chime in if they spot anything else.
It would be great if you could also add a section to the readme about how to use this feature - pointing out that the custom data is expected to be a string -> object mapping.
To aid with testing, please try out these changes (if you haven't already) and let me know the name of your Raygun plan or/and application where you send this data so I can verify things are coming through correctly - or just post some screen shots of test data. It would be good to test passing an invalid value to custom data, and a simple string -> object mapping, and also custom data where the object is not just a primitive object, e.g. an object with properties or an array.

Comment thread main.php Outdated
Comment thread main.php Outdated

@TheRealAgentK TheRealAgentK left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some feedback to the raised items, otherwise it's a good change imho.

It'd be great if after making adjustments, this could be tested and validated with screenshots (or an off-PR conversation with @QuantumNightmare as he suggested to look into your RG data).

@sumitramanga

Copy link
Copy Markdown
Contributor

@robbieaverill Not sure if you have knowledge in Wordpress - Is it possible to have a peek of this PR if you do please? Just when you have some time :)

@robbieaverill

Copy link
Copy Markdown

Hi @sumitramanga, no, I don't have any WP experience, sorry.

@sumitramanga

Copy link
Copy Markdown
Contributor

@robbieaverill No worries, thank you for replying!!

@sumitramanga

Copy link
Copy Markdown
Contributor

Hi @groenroos ! Just wanted to check in and see if you can please apply the changes in order for us to move forward with this PR :) Looking forward to hearing from you!

@groenroos

Copy link
Copy Markdown
Author

Hi @sumitramanga - apologies for the delay! I've now addressed the review comments, and added a section to the readme for documentation as requested.

We're still in the process of integrating this plugin to our current setup on our side, so we're not yet in a place to do any comprehensive testing in our real environment. Let me know if this isn't something you can test on your end, and I can add it to our roadmap!

@TheRealAgentK

Copy link
Copy Markdown

Hi @sumitramanga - apologies for the delay! I've now addressed the review comments, and added a section to the readme for documentation as requested.

We're still in the process of integrating this plugin to our current setup on our side, so we're not yet in a place to do any comprehensive testing in our real environment. Let me know if this isn't something you can test on your end, and I can add it to our roadmap!

Thanks @groenroos - I've resolved the two comments because I think they've been addressed well.

We'll have a chat internally if and how we can go about testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hook to attach custom data

5 participants