-
Notifications
You must be signed in to change notification settings - Fork 189
fix(models): audit fp32 protected tensors #2598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
68f98aa
fix(models): audit fp32 protected dtype casts
yuhezhang-ai 0abf403
fix(gpt-oss): isolate attention sinks in fp32 holder
yuhezhang-ai 0611261
fix(nemotron-v3): isolate mamba fp32 params
yuhezhang-ai a0e0317
fix(nemotron-v3): keep mamba D fp32
yuhezhang-ai 4a73380
fix(distributed): keep fp32 holders unresharded in forward
yuhezhang-ai 00f3e9b
fix(distributed): thread reshard through dtype-aware sharding
yuhezhang-ai b035704
fix(distributed): warn on pp reshard override
yuhezhang-ai 9e1db7b
fix(gpt-oss): keep attention sinks resident dtype
yuhezhang-ai f623f08
Merge remote-tracking branch 'origin/main' into yuhez/fix/fp32-protec…
yuhezhang-ai 6c82ec2
Merge branch 'main' into yuhez/fix/fp32-protected-tensor-audit
akoumpa 3c516cf
fix(models): harden fp32 protected tensor gathers
yuhezhang-ai 0d5f9f1
Merge remote-tracking branch 'origin/main' into yuhez/fix/fp32-protec…
yuhezhang-ai 7bc4c56
fix(models): clone fp32 holder outputs after gather
yuhezhang-ai 9dbf3d9
fix(distributed): reshard fp32 holder submodules normally
yuhezhang-ai 2f115f3
Preserve Nemotron fp32-protected dtypes in HF export
yuhezhang-ai 523aa92
fix(checkpoint): preserve qwen gdn fp32 export dtypes
yuhezhang-ai 9965deb
Merge branch 'main' into yuhez/fix/fp32-protected-tensor-audit
akoumpa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM — clean PR. The fp32 holder pattern, reshard threading, and state-dict adapter routing all look correct. Good test coverage across models and distributed paths.