[opt] Expand measurements: handle !cc.stdvec<!cc.measure_handle>#4405
Open
khalatepradnya wants to merge 4 commits intoNVIDIA:mainfrom
Open
[opt] Expand measurements: handle !cc.stdvec<!cc.measure_handle>#4405khalatepradnya wants to merge 4 commits intoNVIDIA:mainfrom
!cc.stdvec<!cc.measure_handle>#4405khalatepradnya wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
khalatepradnya
requested review from
1tnguyen,
atgeller,
sacpis and
schweitzpgi
atgeller
reviewed
Apr 30, 2026
CI Summary — ✅ passedRun #25239093152 · trigger Top-level jobs (13)
⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch
All sub-jobs (50) — every matrix leg, with links
✅ Required checks (8/8) — declared in
|
| Required check | Status | Link |
|---|---|---|
| Build and test (amd64, clang16, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, clang16, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, gcc11, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, gcc11, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (arm64, clang16, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (arm64, clang16, openmpi) / Dev environment (Python) | ✅ success | view |
Widen the `expand-measurements` pass to lower vector-form `quake.mz`/`mx`/`my` whose result is `!cc.stdvec<!cc.measure_handle>`, mirroring the legacy `!cc.stdvec<!quake.measure>` path. Adds a secondary `ExpandStdvecHandleDiscriminate` pattern for the post-SSA-boundary case where `quake.discriminate` consumes a handle vector that the bridge has stored to / loaded from memory. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
khalatepradnya
force-pushed
the
pkhalate/measure-handle-pr3a-expand-measurements
branch
from
a741bb4 to
2700124
Compare
sacpis
approved these changes
May 5, 2026
Collaborator
sacpis
left a comment
sacpis
left a comment
There was a problem hiding this comment.
Overall LGTM. Thanks @khalatepradnya. Left a few comments.
CI Summary (
|
| Job | Result |
|---|---|
binaries |
⏩ skipped |
build_and_test |
✅ success |
config_devdeps |
✅ success |
config_source_build |
⏩ skipped |
config_wheeldeps |
✅ success |
devdeps |
✅ success |
docker_image |
⏩ skipped |
gen_code_coverage |
⏩ skipped |
metadata |
✅ success |
python_metapackages |
⏩ skipped |
python_wheels |
⏩ skipped |
source_build |
⏩ skipped |
wheeldeps |
✅ success |
⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch
| Job |
|---|
binaries |
config_source_build |
docker_image |
gen_code_coverage |
python_metapackages |
python_wheels |
source_build |
All sub-jobs (40) — every matrix leg, with links
| Job | Status | Link |
|---|---|---|
| Build and test (amd64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| CI Summary | ❔ in_progress | view |
| Configure build (devdeps) | ✅ success | view |
| Configure build (source_build) | ⏩ skipped | view |
| Configure build (wheeldeps) | ✅ success | view |
| Create CUDA Quantum installer | ⏩ skipped | view |
| Create Docker images | ⏩ skipped | view |
| Create Python metapackages | ⏩ skipped | view |
| Create Python wheels | ⏩ skipped | view |
| Gen code coverage | ⏩ skipped | view |
| Load dependencies (amd64, gcc12) / Caching | ✅ success | view |
| Load dependencies (amd64, gcc12) / Finalize | ✅ success | view |
| Load dependencies (amd64, gcc12) / Metadata | ✅ success | view |
| Load dependencies (amd64, llvm) / Caching | ✅ success | view |
| Load dependencies (amd64, llvm) / Finalize | ✅ success | view |
| Load dependencies (amd64, llvm) / Metadata | ✅ success | view |
| Load dependencies (arm64, gcc12) / Caching | ✅ success | view |
| Load dependencies (arm64, gcc12) / Finalize | ✅ success | view |
| Load dependencies (arm64, gcc12) / Metadata | ✅ success | view |
| Load dependencies (arm64, llvm) / Caching | ✅ success | view |
| Load dependencies (arm64, llvm) / Finalize | ✅ success | view |
| Load dependencies (arm64, llvm) / Metadata | ✅ success | view |
| Load source build cache | ⏩ skipped | view |
| Load wheel dependencies (amd64, 12.6) / Caching | ✅ success | view |
| Load wheel dependencies (amd64, 12.6) / Finalize | ✅ success | view |
| Load wheel dependencies (amd64, 12.6) / Metadata | ✅ success | view |
| Load wheel dependencies (amd64, 13.0) / Caching | ✅ success | view |
| Load wheel dependencies (amd64, 13.0) / Finalize | ✅ success | view |
| Load wheel dependencies (amd64, 13.0) / Metadata | ✅ success | view |
| Load wheel dependencies (arm64, 12.6) / Caching | ✅ success | view |
| Load wheel dependencies (arm64, 12.6) / Finalize | ✅ success | view |
| Load wheel dependencies (arm64, 12.6) / Metadata | ✅ success | view |
| Load wheel dependencies (arm64, 13.0) / Caching | ✅ success | view |
| Load wheel dependencies (arm64, 13.0) / Finalize | ✅ success | view |
| Load wheel dependencies (arm64, 13.0) / Metadata | ✅ success | view |
| Prepare cache clean-up | ❔ in_progress | view |
| Retrieve PR info | ✅ success | view |
⚠️ Required checks (4/6) — 2 missing — declared in .github/required-checks.yml for push
| Required check | Status | Link |
|---|---|---|
| Build and test (amd64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (amd64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Debug) | ✅ success | view |
| Build and test (arm64, llvm, openmpi) / Dev environment (Python) | ✅ success | view |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Debug) | ❔ missing | |
| Build and test (amd64, gcc12, openmpi) / Dev environment (Python) | ❔ missing |
Signed-off-by: Pradnya Khalate <pkhalate@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--expand-measurementsto scalarizequake.mz/mx/my%veq -> !cc.stdvec<!cc.measure_handle>.!cc.measure_handlethroughConvertToQIRAPI#4404Motivation
The pass previously hardcoded
!quake.measurefor per-element output and only handledquake.discriminateconsumers of the vector result. Handle-typed vector measurements require per-element!cc.measure_handleoutput and can flow to non-discriminate consumers (returns, stores, calls), neither of which the legacyvector<bool>-only rewrite supported.What Changed
ExpandRewritePatterntracks the input stdvec's element type and emits per-element measurements of the matching type (!quake.measureor!cc.measure_handle).!cc.stdvec<!quake.measure>inputs always allocate the i1 buffer so existing AST-Quake CHECK lines stay stable.replaceOp(atomic) instead oferaseOp, so partial conversion does not try to re-legalize downstreamfunc.returnconsumers.test/Transforms/expand_measurements_handle.qkecovers handle stdvec with each consumer class (return-only, discriminate-only, mixed,cc.store), mixedref + veqoperands, andmx/myparity.