Add client directive support in GraphQLQueryRequestOptions#938
Draft
Add client directive support in GraphQLQueryRequestOptions#938
Conversation
485f9bd to
a6d1102
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
operationFieldDirectivesparameter toGraphQLQueryRequestOptionsto allow passinggraphql.language.Directivedirectives to be applied to the top-level operation field in the serialized query.Refactors this PR #935 and requires a bit more verbose setup to build a Directive on the user side but leverages the existing Directive type instead of creating a new one, and adds it to the options field to avoid adding a parameter to
GraphQLQueryRequestand for extensibility.Open to feedback on if we want to keep the simplified Directive class from the original PR and let the user pass in that type so they don't have to construct a
graphql.language.Directivelike