added support for defining prefixes as : in the fs#14
added support for defining prefixes as : in the fs#14dxlr8r wants to merge 1 commit intoNicolasT:masterfrom
Conversation
|
I'm afraid I don't fully understand what this PR brings... Could you explain a bit more? Thank you! |
|
When using helm charts, plain old regular yml files, etc. with Kubernetes, they have the prefix (if any) already defined. One definition might be: Another: So for using static-container-registry with Kubernetes resources, without manually altering all charts etc., one needs the possibility to define the prefix, or remove it, per image. |
|
Ah, I think I get it now. In the project for which this tools was initially developed we have something similar, but there we keep all images that have a different prefix in other directories (could be subdirectories of your |
|
Ahhh, I see. Yes, that is possible as well. For us, that approach will require more steps to automate. I do prefer the way suggested in the pull request, but I could your method work for us as well. |
|
Fair enough :) Seems like a useful feature. Could you add some tests to the suite to validate the changes? There may be a way to calculate the Looks like TravisCI isn't picking up the PR either, and DockerCloud tests is broken sigh. I'll need to look into that. |
This is my first experience with Python, hardly coded a single line outside of "hello worlds". The "sname" was more a proof of concept, I do not know if that is the best name either. I'll see what I can manage. |
Great project. However, we need to be able to add support for prefixes without defining it for all repositories.
Now I can do:
And I can pull it as normal: