feat: prevent proposals with duplicate actions in GovernorTimelockCom…#6488
Open
xu-nicolas wants to merge 1 commit intoOpenZeppelin:masterfrom
Open
feat: prevent proposals with duplicate actions in GovernorTimelockCom…#6488xu-nicolas wants to merge 1 commit intoOpenZeppelin:masterfrom
xu-nicolas wants to merge 1 commit intoOpenZeppelin:masterfrom
Conversation
…pound Reject proposals at creation time if they contain two or more actions with the same target, value, and calldata. This avoids the scenario where a proposal appears to succeed in voting but can never be executed because the Compound Timelock enforces uniqueness of queued transactions. Closes OpenZeppelin#6431
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pound
Reject proposals at creation time if they contain two or more actions with the same target, value, and calldata. This avoids the scenario where a proposal appears to succeed in voting but can never be executed because the Compound Timelock enforces uniqueness of queued transactions.
Closes #6431
Fixes #????
PR Checklist
npx changeset add)