Conversation
1. remove distinction between SIPNET v1 and v2 (grey text, boxes, arrows for v1) 2. N fixation points to 'plant uptake' rather than 'N min'. I wasn't sure if it should point to the plant itself, but I think that it is more consistent with the model to point it to the 'plant uptake' flux
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Fertilizer can also add C (to litter pool, or soil if litter is off) and organic N (to litter pool) |
Alomir
left a comment
Alomir
left a comment
There was a problem hiding this comment.
Add other fertilizer arrows?
These are the 'non-crop organic matter' boxes. Although SIPNET treats these as 'fertilizer', they are conceptually different. Were there other arrows? |
Summary
BEFORE
AFTER
(grey background is an artifact of exporting the svg to png; it won't shouldn't show up on the webpage; the first image is just a screenshot)
How was this change tested?
I looked at it
Reproduction steps
NA
Related issues
NA
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run
git clang-formatto format staged changes.