Conversation
Cpp-Linter Report
|
|
@copilot Please update unit tests for these changes by:
|
Agent-Logs-Url: https://github.com/PecanProject/sipnet/sessions/3491dabf-5167-435f-b694-ee10c5d4ca0e Co-authored-by: Alomir <1099935+Alomir@users.noreply.github.com>
- Fix resetFluxes() placement in sipnet.c: move from calculateFluxes() to updateState() before processEvents(), so event fluxes are visible during N limitation calculations - Fix LEAFON/LEAFOFF param parsing in events.c: use numRead > 0 instead of != 0 to handle empty/whitespace-only param strings (sscanf returns EOF=-1 for empty input, not 0) - Fix LEAFOFF event bug: use plantLeafC instead of plantWoodC when computing how much leaf C falls - Update russell_2 smoke test reference output to use correct fert event field names (eventLitterN instead of eventOrgN) - Update russell_1/2/3 smoke test reference outputs to reflect correct model behavior with working irrigation events - Add tests/sipnet/test_events_types/testEventLeafOnOff.c - Add event input files for leaf on/off tests - Add tests/sipnet/test_modeling/events_leaf.in - Update tests/sipnet/test_modeling/testBalance.c with testBalanceLeafEvents()" Agent-Logs-Url: https://github.com/PecanProject/sipnet/sessions/3491dabf-5167-435f-b694-ee10c5d4ca0e Co-authored-by: Alomir <1099935+Alomir@users.noreply.github.com>
Agent-Logs-Url: https://github.com/PecanProject/sipnet/sessions/3491dabf-5167-435f-b694-ee10c5d4ca0e Co-authored-by: Alomir <1099935+Alomir@users.noreply.github.com>
Done in commit 73a7611. Here's what was added:
Three bugs were also fixed in the process:
|
Summary
How was this change tested?
List steps taken to test this change, with appropriate outputs if applicable
If changes are needed for any
sipnet.outfiles in thetest/smokesubdirectories, then include output fromtools/smoke_check.pyby running the commands below and pasting the output at the end of this PR. Note thatthis must be run BEFORE submitting changes to any
sipnet.outfiles.Run
python tools/smoke_check.py helpfor more info.TBD
Related issues
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run
git clang-formatto format staged changes.