Skip to content

Jsonb#29

Merged
SebastianStehle merged 5 commits into
PhenX:masterfrom
SebastianStehle:jsonb
May 24, 2025
Merged

Jsonb#29
SebastianStehle merged 5 commits into
PhenX:masterfrom
SebastianStehle:jsonb

Conversation

@SebastianStehle

Copy link
Copy Markdown
Collaborator

No description provided.

@SebastianStehle SebastianStehle requested a review from PhenX as a code owner May 23, 2025 22:14
@SebastianStehle

Copy link
Copy Markdown
Collaborator Author

I added JSON support. I am not sure if it necessarily solves the JSON issue that is open. I have realized that you have to use the postgresql writer a little bit differently in some cases. I also noticed then that this method can be used for SQLite and got rid of some code there.

Furthermore I tried to find a consistent naming for of tests.

@SebastianStehle

Copy link
Copy Markdown
Collaborator Author

Could you make a release when and if you merge it?

@PhenX

PhenX commented May 24, 2025

Copy link
Copy Markdown
Owner

Well that's great but I'd like to be able to merge my PR someday, I'm still on the back merge from master 😅

@SebastianStehle

Copy link
Copy Markdown
Collaborator Author

Sure, I'll wait.

…workCore.BulkInsert into jsonb

# Conflicts:
#	src/PhenX.EntityFrameworkCore.BulkInsert.MySql/MySqlBulkInsertProvider.cs
#	src/PhenX.EntityFrameworkCore.BulkInsert.PostgreSql/PostgreSqlBulkInsertProvider.cs
#	src/PhenX.EntityFrameworkCore.BulkInsert.SqlServer/SqlServerBulkInsertProvider.cs
#	src/PhenX.EntityFrameworkCore.BulkInsert.Sqlite/SqliteBulkInsertProvider.cs
@SebastianStehle

Copy link
Copy Markdown
Collaborator Author

Conflicts merged.

@SebastianStehle SebastianStehle merged commit 685ff84 into PhenX:master May 24, 2025
1 check passed
@SebastianStehle SebastianStehle deleted the jsonb branch May 24, 2025 11:47
@PhenX

PhenX commented May 24, 2025

Copy link
Copy Markdown
Owner

I would have liked to review it, and release it myself

@SebastianStehle

Copy link
Copy Markdown
Collaborator Author

Sry, I really wanted to test this with Squidex. Will not do it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants