Fix Oracle bulk insert schema qualification issues#97
Conversation
- Fix double-schema qualification when EF Core default schema is configured - Clarify table name handling comment
|
I cant speak for Oracle. But is the whole Trace stuff not part of .NET itselt? Something like ActivitySource? And where is it actually used? I don't see it. In general I am big fan of it, but I would make a seperate PR. |
|
@DPschichholz thank you for your contribution, but I agree with @SebastianStehle : while I like the idea to publish an OpenTelemetry integration, I'd like it to be in another pull request, and with another name as, first, I think we can't publish a Nuget packahe with this prefix, and second, that it should share the same prefix as the other packages, so : PhenX.EntityFrameworkCore.BulkInsert.OpenTelemetry, but in another pull request, it will require more effort than the single fix for Oracle to be validated. |
PhenX
left a comment
There was a problem hiding this comment.
Please make another pull request for the open telemetry feature
The telemetry integration is optional and can be enabled via |
Fix Oracle bulk insert ORA-39831 when EF Core default schema is configured
Details
When
HasDefaultSchema(...)is set,tableInfo.QuotedTableNamebecomes a SQL-quoted fully qualified identifier (e.g."SchemaX"."TableA"). Passing this toOracleBulkCopy.DestinationTableNamecauses ODP.NET to double-apply the schema, producingSchemaX.SchemaX.TableAand failing withORA-39831.Change
OracleBulkInsertProvider.BulkInsert: computedestinationTableNamebefore assigning tobulkCopy.DestinationTableName:tableName == tableInfo.QuotedTableName): usetableInfo.TableName(plain unquoted name — ODP.NET resolves the schema itself)tableNameunchanged