Fix resource pack UUID serialization causing server kick on 1.21+

[Copilot]

• Fix latestUUID storage: store raw bytes (data.uuid) not UUID object, in both add_resource_pack and resource_pack_send handlers
• Fix denyResourcePack double-write bug
• Remove all feature branching from acceptResourcePack and denyResourcePack — protodef ignores extraneous fields so version checks are unnecessary
• Move latestUUID and latestHash assignments outside the if/else in resource_pack_send so both are always stored
• Lint passes, CodeQL: 0 alerts

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Kicks from the server when receiving a resource pack.</issue_title>
<issue_description>- [ ] The FAQ doesn't contain a resolution to my issue

Versions

• mineflayer: 4.33.0
• server: BungeeCord 1.21-R0.4 - Paper
• node: 24.1.0

Detailed description of a problem

There are no problems when logging into the hub, but when connecting to a subserver on version 1.21, the server offers a resource pack, but the problem is I can't accept or decline it. Either way, I get kicked from the server for no reason.

Your current code

import mineflayer from "mineflayer";

const bot = mineflayer.createBot({
    host: 'neo.funtime.sh',
    port: 25565,
    username: '6055_42',
    version: '1.21.8'
});

bot.on('spawn', () => {
    console.log('Join to anarchy')
    bot.chat("/an11") // Joining a server with version 1.21 from the lobby (BungeeCord)
})
bot.on('resourcePack', () => {
    console.log('Resource pack received');
    bot.acceptResourcePack();
    console.log('Resource pack accepted');
})
bot.on('message', (message) => {
    console.log(`${message.toString()}`)
})
bot.on('kicked', (reason) => {
    console.log('Kicked:', reason);
})
bot.on('error', (error) => {
    console.error(`Error: ${error}`);
})
bot.on('end', (reason) => {
    console.log(`End: ${reason}`);
})

Expected behavior

Successful connection to the server without kicking; resource pack is not important.
</issue_description>

<agent_instructions>Add the code posted by MayorLeon20 to our acceptResourcePack handling</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@extremeheat acceptResourcePack needs to be fixed and simplify

• Fixes Kicks from the server when receiving a resource pack. #3768

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[MayorLeon20]

everything is cool

[extremeheat]

This branch is unnecessary

[Copilot]

Removed the branch — denyResourcePack now unconditionally writes a single packet with uuid included. Done in 708fd6f.

[extremeheat]

These branches are also unnecessary

[Copilot]

Removed all feature branching from acceptResourcePack — it now always writes both packets with uuid and hash fields unconditionally (protodef drops fields not in the version's schema). Done in 708fd6f.

[extremeheat]

@copilot since protodef will ignore extraneous fields for versions that don't have them, the feature branching is unnecessary. Feature branching is only needed for fields that have different non-null data types between different versions; using different field names removes this need. You can remove them where applicable for cleanliness (sometimes it's helpful to have comments aside fields to notate what version the field applies to)

[Copilot]

@copilot since protodef will ignore extraneous fields for versions that don't have them, the feature branching is unnecessary. Feature branching is only needed for fields that have different non-null ...

Done in 708fd6f. Removed all feature branching from acceptResourcePack and denyResourcePack. Also moved the latestUUID and latestHash assignments in resource_pack_send outside the if/else so both are always stored regardless of version.

[kaduvert]

merge this immediately!