maint: replace deprecated Sass @import with @use#210
Merged
Conversation
Sass @import is deprecated and will be removed in Dart Sass 3.0. The two partials define no variables and share none with main.scss, so @use is a drop-in: compiled main.css is byte-identical and the build log loses all deprecation warnings. Completes the Sass follow-up from #199, now that production builds with the Gemfile's Jekyll 4.4 / Dart Sass toolchain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for grand-swan-ca5201 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the site’s main Sass entrypoint to use modern Dart Sass module directives now that the production build runs with the repo’s Jekyll 4.4 toolchain, removing deprecated Sass @import usage.
Changes:
- Replaced Sass
@import 'misc'and@import 'timeline'with@useequivalents inassets/main.scss. - Left the plain-CSS
@import url(...)(Google Fonts) untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #205 — completes the Sass follow-up from #199. Now that production builds with the Gemfile's Jekyll 4.4 / Dart Sass toolchain (instead of the legacy Pages sandbox), the modern module directives can be used.
Changes
assets/main.scss:@import 'misc'/@import 'timeline'→@use 'misc'/@use 'timeline'. The plain-CSS@import url(...)for Google Fonts is untouched — that form is not deprecated, and Dart Sass hoists it to the top of the compiled output where browsers require it.Both partials are pure CSS rules — they define no Sass variables and reference none from
main.scss— so@usenamespacing changes nothing.Verified
_site/assets/main.cssis byte-identical before and after the change.DEPRECATION WARNING [import]noise (previously one per@importper build).Note on the other #199 follow-up
"Drop the
github-pagesgem" turned out to be already done — the Gemfile has run plainjekyll ~> 4.4since the redesign. With this PR, all #199 follow-ups are complete.🤖 Generated with Claude Code
Note: #205 also mentions restoring
@forwardand converting@importrules insideassets/sass/— neither applies: the original pre-workaround code (65163f9) never used@forward, and the partials contain no@importrules. This PR reverts exactly what the workaround changed.