Fix squeeze dimension in test logits calculation#28
Open
JulianAssmann wants to merge 1 commit into
Open
Conversation
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27.
Issue
SAP_RPT_OSS_Regressor.predict()raised an error when called with a single-row DataFrame during regression tasks:The root cause is In sap_rpt_oss/model/torch_model.py, line 361, where
.squeeze()is called without specifying a dimension. When there is only one test sample, this removes all size-1 dimensions, collapsing the tensor to a 0-d scalar. The subsequentnp.concatenatecall then fails because it cannot concatenate zero-dimensional arrays.Fix
Reproduce bug and verify fix