feat: add optional ROS 2 Lifecycle support and fix shutdown deadlock#552
Open
BOOPESH-foxy wants to merge 3 commits into
Open
feat: add optional ROS 2 Lifecycle support and fix shutdown deadlock#552BOOPESH-foxy wants to merge 3 commits into
BOOPESH-foxy wants to merge 3 commits into
Conversation
- Implemented standard ROS 2 Managed Node interface (Configure, Activate, Deactivate, Cleanup). - Resolved MsgPack thread deadlock in scansegment_xd via async signaling. - Updated 30+ launch files to support 'lifecycle_managed_node' argument. - Added technical documentation in doc/lifecycle_node.rst and updated CHANGELOG. - Maintained 100% backward compatibility for ROS 1 and standard ROS 2 builds.
Collaborator
|
Dear @BOOPESH-foxy Thank you very much for your tickets and the resulting suggestions for improvement. We will review the PR and evaluate and test your changes during March. |
This was referenced Feb 17, 2026
Collaborator
|
All in all, the changes look good. To make coordination with SICK management easier, we’ve created the feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces optional support for ROS 2 Managed Nodes (Lifecycle) and resolves a critical shutdown deadlock in the
scansegment_xdcomponent.Key Changes
rclcpp_lifecyclestate machine. Users can now toggle between standard and managed nodes using thelifecycle_managed_node:=trueargument.MsgPackhandling withinscansegment_threads.cppby implementing asynchronous signaling during the shutdown sequence.doc/lifecycle_node.rst.Related Issues