Nick pape/wip#4
Closed
nick-pape wants to merge 41 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds example SharePoint Framework (SPFx) projects demonstrating various component types and configurations. It includes web parts, extensions, and a library, each showcasing different frameworks (React, no framework) and build configurations using Heft.
- Adds 8 example projects covering web parts, extensions (list view command set, form customizer, search query modifier), and a library
- Provides TypeScript configurations, ESLint setups, and Webpack configurations for each example
- Includes comprehensive build, test, and deployment configurations using the Heft build system
Reviewed changes
Copilot reviewed 274 out of 358 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/webpart-react/.eslintrc.js | ESLint configuration for React-based web part example |
| examples/webpart-noframework/webpack.config.js | Webpack configuration for no-framework web part |
| examples/webpart-minimal/.eslintrc.js | ESLint configuration for minimal web part example |
| examples/library/webpack.config.js | Webpack configuration for SPFx library component |
| examples/extension-search-query-modifier/webpack.config.js | Webpack configuration for search query modifier extension |
| examples/extension-listviewcommandset/src/extensions/listViewCommandSet/ListViewCommandSetCommandSet.ts | Implementation of list view command set extension |
| examples/extension-formcustomizer-react/src/extensions/reactFormCustomizer/ReactFormCustomizerFormCustomizer.ts | React-based form customizer extension implementation |
| examples/extension-formcustomizer-noframework/src/extensions/noFrameworkFormCustomizer/NoFrameworkFormCustomizerFormCustomizer.ts | No-framework form customizer extension implementation |
| apps/spfx-cli/eslint.config.js | Removes base ESLint configuration file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ommandSet/ListViewCommandSetCommandSet.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o nick-pape/wip
Resolved conflicts by: - Accepting refactored code structure (split repository source files) - Keeping EJS types and proper API usage - Maintaining eslint ^8.57.1 for consistency across repo - Merging test configurations to test both hello-world and real templates - Keeping our rush.json with all template packages Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove eslint.config.js (flat config not supported in ESLint 8) - Fix typo: componentNameHypenCase → componentNameHyphenCase in templates - Update examples to match current template output - Update lockfiles from rush update All tests now pass successfully. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Merges all changes from main (templates, skills, CLAUDE.md, AGENTS.md, etc.) into the WIP branch. Removes old-format source files and build configs (heft.json, jest.config.json, webpack.config.js, en-us.resjson, myWebPart/* stubs) from examples that already exist in main, keeping main's versions as the source of truth. New content unique to this branch is preserved: - examples/ace-generic-basic-card/ - examples/ace-generic-image-card/ - examples/ace-generic-primarytext-card/ - examples/library/ - templates/test/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…in main) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nick-pape
commented
Feb 25, 2026
- Remove .claude/settings.local.json (should not be checked in) - Remove .vscode/extensions.json (should not be checked in) - Remove api/spfx-template-api/etc/generator-sharepoint-api.api.md - Remove docs/Templates.md - Remove templates/test/ (no longer needed) - Remove baseline-browser-mapping from common-versions.json - Revert tools/spfx-cli-build-rig/package.json to main version - Revert libraries/spfx-templating-engine/package.json to main version Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The merge produced hundreds of duplicate keys throughout the lockfile. Since the new WIP examples are not registered in rush.json, main's lockfile is the correct baseline. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…red fields The WIP branch had added three duplicate TemplateConfig entries (webpart-noframework, webpart-minimal, webpart-react) at the bottom of TEMPLATE_CONFIGS using the old format that lacked the required localTemplatePath and componentName fields. These duplicates already exist earlier in the array in the correct format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removes old aceImage/acePrimaryText/library component dirs and legacy heft.json/jest.config.json/webpack.config.js files that were left over from the wip branch but were superseded by the cleaner versions merged via PRs #59, #60, and the library template PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.