Skip to content

chore: upgrade xo to 2.0#8907

Merged
BKSteve merged 2 commits into
SickChill:developfrom
MattPark:chore/xo-2-migration
May 4, 2026
Merged

chore: upgrade xo to 2.0#8907
BKSteve merged 2 commits into
SickChill:developfrom
MattPark:chore/xo-2-migration

Conversation

@MattPark

@MattPark MattPark commented May 1, 2026

Copy link
Copy Markdown

Summary

  • Bumps xo from ^1.1.0 to ^2.0.2 (ESLint 10)
  • Suppresses new rules that fire on legacy jQuery code (require-unicode-regexp, unicorn/no-immediate-mutation, @stylistic/curly-newline, unicorn/no-array-sort, max-lines)
  • yarn test passes cleanly (6 warnings only — long lines in legacy files)

Closes #8879

Notes

The suppressed rules all fire exclusively on core.js (4500-line legacy jQuery file) which will eventually be replaced by the webpack frontend. Not worth refactoring now.

Bump xo from ^1.1.0 to ^2.0.2 (ESLint 10). Suppress new rules
(require-unicode-regexp, unicorn/no-immediate-mutation, etc.) that fire
on legacy jQuery code not worth refactoring.

Closes SickChill#8879
@coderabbitai

coderabbitai Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • chore
  • bump

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3eaac4c2-18dd-43df-a510-ee4c88ac7b88

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@BKSteve BKSteve enabled auto-merge (squash) May 2, 2026 14:07
@BKSteve BKSteve disabled auto-merge May 2, 2026 14:07
@BKSteve BKSteve merged commit c184742 into SickChill:develop May 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants