Statistics#8694
Open
AnOwlBe wants to merge 26 commits into
Open
Conversation
AnOwlBe
requested review from
TheMug06 and
erenkarakal
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
erenkarakal
requested changes
Jun 9, 2026
erenkarakal
left a comment
erenkarakal
left a comment
Member
There was a problem hiding this comment.
just some nitpicks, the code itself seems fine
skriptlang-automation
Bot
removed
the
needs triage
ShaneBeee
suggested changes
Jun 9, 2026
ShaneBeee
left a comment
ShaneBeee
left a comment
Contributor
There was a problem hiding this comment.
Just some small nitpicks, looks good otherwise.
Co-authored-by: Shane Bee <shanebolenback@me.com>
Author
I just followed what was said in burb's statistic pr the methods were private yet it was still suggested javadocs for the methods
|
Absolutionism
requested changes
Jun 9, 2026
Comment on lines
+3
to
+6
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.1-bin.zip | ||
| networkTimeout=10000 | ||
| retries=0 | ||
| retryBackOffMs=500 |
Contributor
There was a problem hiding this comment.
What's going on with these gradle changes?
Author
There was a problem hiding this comment.
unsure I made the branch like 3d ago then worked on it then pushed it then made the pr and its just showing that these were added last month
skriptlang-automation
Bot
removed
the
needs reviews
…nts/events/EvtPlayerStatisticChange.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
requested changes
Jun 9, 2026
Author
|
oh forgot one of the catch runtime errors give me a sec |
Absolutionism
requested changes
Jun 10, 2026
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Absolutionism
requested changes
Jun 10, 2026
Absolutionism
approved these changes
Jun 10, 2026
ShaneBeee
approved these changes
Jun 10, 2026
ShaneBeee
suggested changes
Jun 14, 2026
Author
|
oh lol forgot to put a commit message eh should be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Notch added statistics in 2011 and Bukkit added them to their API at some point later on.
Nowdays they are a very useful utility for getting how many times a player e.g. broke sand or killed another player etc without having to deal with tracking that information yourself.
Solution
Added
ExprStatisticusage example:send player kills statistic of mesend mine block stat using tnt (itemtype) of mesend me's deaths statisticadd 52 to player kills stat of meremove 2490 from player kills stat of meset player kills stat of me to 5Added an EvtPlayerStatisticChange called when the server updates the statistic of a player (from my testing it is not called if you modify the statistic of a player only when the server does it eg when you jump etc)
Added an EnumClassInfo for statistics.
Testing Completed
Manual testing done everything appears to work fine
Supporting Information
Continued version of #7568 with a decent chunk of changes
Completes: #4687
Related: #7568 #4704 #1246
AI assistance: Some for finding root of some problems