SCANCLI-220 SubmitReview: Use Vault token#272
SCANCLI-220 SubmitReview: Use Vault token#272pavel-mikula-sonarsource wants to merge 1 commit intomasterfrom
Conversation
SummaryWhat changed: The SubmitReview workflow now retrieves the GitHub token from Vault instead of using the default Why: This migration to Vault-based token management is part of the latest automation changes. It enables centralized token management and consistency across workflows. The same token is already used in RequestReview.yml. What reviewers should knowWhat to review:
Context: This is one of 200+ repos being updated to this pattern. The changes are minimal and follow the RequestReview.yml pattern, so if that workflow is working correctly, this should work the same way.
|
There was a problem hiding this comment.
LGTM! ✅
Clean, minimal change. The resulting SubmitReview.yml is now structurally identical to RequestReview.yml, which already uses this same Vault token pattern successfully. The removal of pull-requests: read is correct — that permission scoped the built-in GITHUB_TOKEN; the Vault-managed token carries its own permissions and doesn't need it.
|





With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.