feat: generate tuple type for fixed-length arrays (min equals max)#231
Open
2wheeh wants to merge 1 commit into
Open
feat: generate tuple type for fixed-length arrays (min equals max)#2312wheeh wants to merge 1 commit into
2wheeh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an array schema has
minItems === maxItems, generate a tuple type instead ofT[].This PR only handles the equal case (
minItems === maxItems).It seems Range support (
minItems !== maxItems→ union of tuple lengths) is easily possible by reusing the existingApplyMinMaxpipeline withRepeat, but left out intentionally due to:estimateCodeSize < 30)Changes
Repeat<T, N>type utility that builds a fixed-length tuple of repeated typeParseArraySchemainarray.tsto checkminItems === maxItemsand produceM.$TupleviaRepeatM.$Array(existing behavior) for all other casesBreaking change
This is technically a narrowing change:
string[]→[string, string]. Code that assigns a generalT[]to aFromSchematype with fixed-length constraints may break. The type is now more correct but stricter — may warrant a minor version bump.