feat: Add effective map location in AbstractDatesetEvents#2385
Open
diogodanielsoaresferreira wants to merge 2 commits into
Open
feat: Add effective map location in AbstractDatesetEvents#2385diogodanielsoaresferreira wants to merge 2 commits into
diogodanielsoaresferreira wants to merge 2 commits into
Conversation
diogodanielsoaresferreira
requested review from
rsynek and
triceo
as code owners
diogodanielsoaresferreira
temporarily deployed
to
internal
GitHub Actions
Inactive
diogodanielsoaresferreira
changed the title
|
mswiderski
approved these changes
Jun 19, 2026
rsynek
reviewed
Jun 22, 2026
| } | ||
| } | ||
|
|
||
| private void enrichResolvedMapLocation(AbstractEvent event) { |
Collaborator
There was a problem hiding this comment.
I don't understand the architecture of how we transfer the resolved map location to the platform.
This code effectively sends the resolved location in every single instance of AbstractDatasetEvent, which includes all intermediate best solution events, and more.
This is a piece of information that gets resolved at enrichment time, but since then, it does not change. Why do we need to keep sending it over and over again?
Which component in the platform needs to know the resolved map location and why?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add effective map location in AbstractDatasetEvents, so that we know which effective location was used when auto-select location was enabled.
Fixes: https://github.com/TimefoldAI/timefold-platform/issues/4452