Accept both levels of invite escaping#2838
Open
bemasc wants to merge 2 commits into
Open
Conversation
Currently only double-escaped invites are supported.
Contributor
|
Funny, you discovered the same bug I spent a few hours tracing towards the end of last week. In cases like this, you can't over-comment - definitely explain that us running jsurl on a JSON-encoded string was just a totally dumb bug that we're kinda stuck supporting now (argh). |
Contributor
Author
|
OK, commented. |
fortuna
reviewed
Dec 6, 2016
fortuna
left a comment
fortuna
left a comment
Contributor
There was a problem hiding this comment.
Could you move the url parsing logic to a separate function? Maybe add a test?
Contributor
|
I guess we can close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only double-escaped invites are supported.
This change is