Skip to content

temp#1859

Open
clinnygee wants to merge 3 commits intomainfrom
issue/1810
Open

temp#1859
clinnygee wants to merge 3 commits intomainfrom
issue/1810

Conversation

@clinnygee
Copy link
Copy Markdown
Collaborator

No description provided.

@clinnygee clinnygee marked this pull request as ready for review April 13, 2026 03:38
@clinnygee clinnygee requested a review from leoniedickson April 13, 2026 03:38
Copy link
Copy Markdown
Collaborator

@leoniedickson leoniedickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clinnygee, looks good but seems like there's one gap:

RepeatItem/RemoveItemButton still has numOfRepeatAnswers === 1 in the disabled check, so the remove button remains disabled when there's only a single non-group repeat answer. The same fix applied to RepeatGroup/RemoveItemButton (dropping the count guard) should be applied here too — RepeatItem.tsx already handles the zero-answers case correctly (emits an empty qrItem when the last answer is removed).

@clinnygee
Copy link
Copy Markdown
Collaborator Author

Hey @clinnygee, looks good but seems like there's one gap:

RepeatItem/RemoveItemButton still has numOfRepeatAnswers === 1 in the disabled check, so the remove button remains disabled when there's only a single non-group repeat answer. The same fix applied to RepeatGroup/RemoveItemButton (dropping the count guard) should be applied here too — RepeatItem.tsx already handles the zero-answers case correctly (emits an empty qrItem when the last answer is removed).

Hey @leoniedickson yes this looks like an oversight, but it behaves a bit weird like that because these fields already have their own clear button. I checked with Liam before changing this back to === 1. I attached a screenshot to
Screenshot 2026-04-20 at 10 48 31 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants