feat: add support for file+metadata streams#119
Conversation
Ryan Br... (tryangul)
force-pushed
the
rbroughan/stream-based-file-and-metadata-support
branch
4 times, most recently
from
0ca5213 to
33b2a3a
Compare
Ryan Br... (tryangul)
changed the title
Ryan Br... (tryangul)
force-pushed
the
rbroughan/stream-based-file-and-metadata-support
branch
from
7c70577 to
bdf1b3c
Compare
Ryan Br... (tryangul)
force-pushed
the
rbroughan/stream-based-file-and-metadata-support
branch
from
66dca60 to
1b050e8
Compare
| @@ -1,3 +1,3 @@ | |||
| # x-release-please-start-version | |||
| VERSION=0.14.3 | |||
| VERSION=0.14.4 | |||
There was a problem hiding this comment.
nit: should this be a minor upgrade since we're adding a feature?
There was a problem hiding this comment.
Per semver spec, MINOR version when you add functionality in a backward compatible manner
Sounds right to me assuming we are following semver and there aren't any externalities (forced connector updates, etc)
There was a problem hiding this comment.
CC Aldo Gonzalez (@aldogonzalez8) any concerns with us flagging this as a minor version bump?
There was a problem hiding this comment.
Bumped to minor pending feedback.
There was a problem hiding this comment.
Davin Chia (@davinchia) is this what you were referring to in standup?
There was a problem hiding this comment.
CC Aldo Gonzalez (@aldogonzalez8) any concerns with us flagging this as a minor version bump?
Alexandre Girard (@girarda) No, being this additive, I think this is correct to be minor.
There was a problem hiding this comment.
Looks like CI does this automatically #119 (comment)
| If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup. | ||
| " | ||
| type: integer | ||
| include_files: |
There was a problem hiding this comment.
is this a no-op if the stream isn't file-based or is the platform expected to crash? Might be good to clarify the expectation in the description
There was a problem hiding this comment.
Yes, but also I was trying to avoid defining platform behavior here, as it could easily drift. I do see there is precedence for stating the platform behavior, however.
I could add "Otherwise, this property will be ignored."
There was a problem hiding this comment.
Went ahead and amended this.
Ryan Br... (tryangul)
force-pushed
the
rbroughan/stream-based-file-and-metadata-support
branch
from
1b050e8 to
f53ac51
Compare
Ryan Br... (tryangul)
force-pushed
the
rbroughan/stream-based-file-and-metadata-support
branch
from
f53ac51 to
03efe1b
Compare
| @@ -1,3 +1,3 @@ | |||
| # x-release-please-start-version | |||
| VERSION=0.14.5 | |||
| VERSION=0.15.0 | |||
There was a problem hiding this comment.
Remove this.
CI will automatically look at the PR title and create a following version bump PR.
There was a problem hiding this comment.
Will it make it appropriately a minor bump or just a patch?
There was a problem hiding this comment.
it'll behave according to the PR title. Feat = minor.
Rules are in the readme!
There was a problem hiding this comment.
Awesome. Un-reving version then will merge on 🟢
Ryan Br... (tryangul)
deleted the
rbroughan/stream-based-file-and-metadata-support
branch
4 participants
What
Adds support for "file based" streams — streams consisting of files and their associated metadata.
These streams may be synced alongside normal streams, enabling a single connection to support both files and records.
Detailed information explaining the motivations of the supported feature and the changes themselves can be found in the proposal doc linked below.
Links
Protocol Proposal Doc
Feature description
Evolution of spike draft