feat(cable): add zellij-sessions channel#1032
Open
Vexo413 wants to merge 1 commit intoalexpasmantier:mainfrom
Open
feat(cable): add zellij-sessions channel#1032Vexo413 wants to merge 1 commit intoalexpasmantier:mainfrom
Vexo413 wants to merge 1 commit intoalexpasmantier:mainfrom
Conversation
| requirements = ["zellij"] | ||
|
|
||
| [source] | ||
| command = "zellij list-sessions | sed 's/\\x1b\\[[0-9;]*m//g'" |
Owner
There was a problem hiding this comment.
it looks like this is trying to strip ansi escape codes from zellij's output.
Reading zellij's code (couldn't find anything in the docs for some reason), it seems they have a --no-formatting option you could use to avoid having to do that.
and as a last resort if the above doesn't work you can also use display = "{strip_ansi}"
Owner
|
Thanks for the PR, looks mostly good to me except for that unnecessary sed expression I mentioned above. |
c999735 to
fa21248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📺 PR Description
Add a zellij-sessions channel for searching through the Zellij multiplexer's sessions, similar to the tmux-sessions channel.
Checklist