vmware_guest: Add typev6 to 'networks' customization check#2316
Open
okopop wants to merge 1 commit into
Open
Conversation
SUMMARY
The behaviour now is that this specific if-statement always hits because typev6 is missing from it and it's always added by default when you define "networks". This gives unexpected behaviour.
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
E.g.
```
networks:
- name: "PORTGROUP_NAME_XYZ"
```
From debug log:
```
"networks": [
{
"name": "PORTGROUP_NAME_XYZ",
"type": "dhcp",
"typev6": "dhcp"
}
```
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 40s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The behaviour now is that this specific if-statement always hits because typev6 is missing from it and it's always added by default when you define "networks". This gives unexpected behaviour.
ISSUE TYPE
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
E.g.
From debug log: