[section 5] Ensure pam update is triggered (WIP)#157
Draft
bykvaadm wants to merge 1 commit intoansible-lockdown:develfrom
Draft
[section 5] Ensure pam update is triggered (WIP)#157bykvaadm wants to merge 1 commit intoansible-lockdown:develfrom
bykvaadm wants to merge 1 commit intoansible-lockdown:develfrom
Conversation
Signed-off-by: Kondratev Alexander <info@bykvaadm.ru>
Contributor
|
Thanks for working on this @bykvaadm. The approach of checking for existing pam_unix entries before template deployment and using
This is a good enhancement. We're tracking it for inclusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of notification improvement.
Why?
if for any reason we can't run role to the end, pam update will never be triggered.
so it's not idempotent without somehow rerunning notifications