Skip to content

test: re-enable part of extrusion failures test #2523

Open
RobPasMue wants to merge 13 commits intomainfrom
test/issue_2292_revolve_helix
Open

test: re-enable part of extrusion failures test #2523
RobPasMue wants to merge 13 commits intomainfrom
test/issue_2292_revolve_helix

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Test was causing a seg fault on docker containers but seems to be fixed now. Re-enabling test.

Issue linked

Closes #2292

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue requested a review from a team as a code owner January 23, 2026 10:51
@RobPasMue
Copy link
Copy Markdown
Member Author

Had to reopen the PR @jacobrkerstetter - this test is super flaky, I've been saying random errors with it. We need to investigate further

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.97%. Comparing base (4a1f094) to head (0acde0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2523   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         174      174           
  Lines       14488    14488           
=======================================
  Hits        13760    13760           
  Misses        728      728           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in ... geometry_commands.revolve_faces_by_helix

3 participants